re: Tankless vs. Tank Water Heaters

You probably should decide first if you are going to use foam.

If you do, that will rule out (generally) putting a combustible unit in the attic.
If you don't, you can use whatever.