re: Expiration of “Trump” tax cuts

Example: married filing joint, $150k taxable income now, $150k annual retirement. Assumptions: no other retirement income, using 2024 brackets without inflation adjustment for simplicity sake (fair because not adjusting withdrawal amount for inflation either).

Tax bracket today: 22% thus each extra dollar you choose to pay tax on and contribute to Roth is taxed at 22% (thus only contributing .78¢) or you defer tax of 22% and contribute that full dollar to traditional.

At retirement the Roth balance will be 22% smaller than equivalent traditional contribution (unless you max annual contributions in which case to compare apples/apples you would invest the excess traditional tax savings either in a Roth IRA, taxable brokerage, etc)

Retirement Withdrawals from traditional are taxed at a lower EFFECTIVE RATE. First, $29k is tax free due to standard deduction. Next $23k taxed at 10% then additional up to $94k taxed at 12%. At that point you have ~$122k of withdrawals that have been taxed at rates from 0-12% (instead of 22% when you earned them) Only at that point does the last $18k get taxed in the 22% bracket.
Even if brackets are raised it isnt likely your bottom brackets will exceed the top rate you pay today (unles low income in which case Roth is easy choice.)
The math can still work in favor of traditional if you have other income in retirement but its a little more nuanced. You can have quite a bit of income before withdrawals are fully taxed in same bracket or higher than during contribution years. Of course there are other considerations such as triggering tax on SS benefits, ACA subsidy income limits, IRMAA, RMDs on traditional but not Roth etc. Thus, it is a good idea to have $ in multiple tax buckets so you can optimize where you pull from in retirement year to year based on needs and situation.