re: Who's your favorite guitarist of all time ?

Too many to mention although Gilmour has been a lifelong obsession . And Knopfler is my default that I never get tired of and who has the most impressive oeuvre over five decades imho .I tend to celebrate more than denigrate. And most of my faves have been discussed . Let me just mention a few that deserve mention:

Frampton- just incredible tone. He was on point as a guitarist at all times , a true craftsman.

Mike Campbell- maybe the most disciplined Accompanist-always in his lane and restrained and in the service of the song.

Steve Morse. C’mon guys. Where is the love for Steve. His Dregs catalogue is mind- blowing.

Nick Drake’s gorgeous finger picking.

Earl Klugh hit the chill button with virtuoso perfection.

Doyle Bramhall ll

Anybody that ever played in Steely Dan .

A million bluegrass/ country artists.
I could go on for days.