re: In ancient warfare was it better to have light cavalry or heavy?

The enemy would dictate this. Sun Tzu said some shite about that.

If the enemy has armor and you have to close with them to kill with hand weapons, heavy cavalry.

If they don't have armor, if the terrain isn't amenable or other factors, then contain them with light cavalry and kill them with bows and other distance weapons.