Undoubtedly the older generations as a whole were better shots. I would have bet on my granddaddy up against anyone back in the day. For them shooting / hunting and hitting your target meant food on the table or going hungry.
In the 20's my grandfather was sent out with a slingshot to bring home squirrel and rabbit for supper. He didnt get to carry his daddies shotgun until his older brothers went off into the army.
^This. My Grandfather could really shoot. He grew up on a farm in the '20s and '30s, and as someone else said it meant food. In the later '30s, he joined the USAAF and eventually became a bombardier. He always said that part of the training (they were also taught gunnery), they did a lot of skeet shooting. He stayed in the USAF until the last '60s. I have plenty of photos of him and his crew showing the results of duck/pheasant hunts in Japan, Korea, etc. And when I say results, you could say truckload would be about right. He hunted up until his 70s or so, and I went on many dove shoots with him. Never saw him miss much at all...